Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename cloud #2766

Merged
merged 3 commits into from
May 17, 2023
Merged

rename cloud #2766

merged 3 commits into from
May 17, 2023

Conversation

cooper-lzy
Copy link
Contributor

What type of PR is this?

  • bug
  • feature
  • enhancement

What problem(s) does this PR solve?

Issue(s) number:

Description:

How do you solve it?

Special notes for your reviewer, ex. impact of this fix, design document, etc:

Copy link
Contributor

@whitewum whitewum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code changes involve renaming "Cloud" to "{{cloud.name}}" in various files.
The changes seem to be consistent with the commit messages.
No bugs or major issues are apparent in the code changes.
The diffs appear to be correctly formatted and applied.
The changes are relatively minor and do not introduce any major functional modifications.
The code changes seem to align with the purpose of the pull request to rename the cloud.
Overall, the code changes look good and align with the commit messages. No major issues or bugs were found.

@whitewum whitewum merged commit 136b866 into vesoft-inc:master May 17, 2023
@cooper-lzy cooper-lzy deleted the rename-cloud branch August 11, 2023 06:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants