Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explorer supports nfs #2726

Merged
merged 6 commits into from
May 17, 2023
Merged

Conversation

cooper-lzy
Copy link
Contributor

What type of PR is this?

  • bug
  • feature
  • enhancement

What problem(s) does this PR solve?

Issue(s) number:

Description:

How do you solve it?

Special notes for your reviewer, ex. impact of this fix, design document, etc:

@cooper-lzy cooper-lzy changed the title Explorer support nfs Explorer supports nfs Apr 23, 2023
whitewum
whitewum previously approved these changes Apr 25, 2023
Copy link
Contributor

@whitewum whitewum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Patch 1/5:

The commit message states that the change adds support for NFS to the explorer.
The change modifies the file version-upgrade.md in the nebula-dashboard-ent/4.cluster-operator/operator directory.
No bugs or issues found.
Patch 2/5:

The commit message is vague and doesn't provide much information about the change.
The change modifies the files 2.create-workflow.md and workflows.md in the nebula-explorer/workflow directory.
The modifications seem to be related to updating the documentation with new images and clarifying the inputs and results of components.
No bugs or issues found.
Patch 3/5:

The commit message indicates an update to the 1.prepare-resources.md file.
The change modifies the file 1.prepare-resources.md in the nebula-explorer/workflow directory.
The modification updates an image in the documentation to reflect the changes in the user interface.
No bugs or issues found.
Patch 4/5:

The commit message indicates an update to the 1.prepare-resources.md file.
The change modifies the file 1.prepare-resources.md in the nebula-explorer/workflow directory.
The modification updates the documentation by changing some wording.
No bugs or issues found.
Patch 5/5:

The commit message is vague and doesn't provide much information about the change.
The change modifies the file 1.prepare-resources.md in the nebula-explorer/workflow directory.
The modification updates the documentation by changing some wording.
No bugs or issues found.
Overall, the code changes seem to align with their respective commit messages. No major issues or bugs were found. The changes mostly involve updating the documentation, adding support for NFS, and improving the user interface images.

@whitewum whitewum merged commit 0c1befd into vesoft-inc:master May 17, 2023
@cooper-lzy cooper-lzy deleted the explorer-support-nfs branch August 11, 2023 06:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants