Add profile and explain command for console #2437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
follow up of vesoft-inc/nebula-console#186 This will be highlighted in forum and GitHub issues too to avoid user sharing pictures from the console or studio, or CSV outputs
whitewum
approved these changes
Jan 5, 2023
abby-cyber
approved these changes
Jan 5, 2023
abby-cyber
added a commit
that referenced
this pull request
Jan 5, 2023
This reverts commit 5394d38.
abby-cyber
reviewed
Jan 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
follow up of vesoft-inc/nebula-console#186 This will be highlighted in forum and GitHub issues too to avoid user sharing pictures from the console or studio, or CSV outputs
What type of PR is this?
What problem(s) does this PR solve?
Issue(s) number:
vesoft-inc/nebula-console#186
Description:
Highlight a new/proper way of collection for profile results
How do you solve it?
Introduce
:profileor:explain, it will output results(not just dot format) to files. We need to highlight it in forums etc. too.Special notes for your reviewer, ex. impact of this fix, design document, etc: