Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Highlight somewhere in docs on property filter in bulk pattern's condition #824

Closed
wey-gu opened this issue Aug 12, 2021 · 7 comments
Closed

Comments

@wey-gu
Copy link
Contributor

wey-gu commented Aug 12, 2021

It's easy for users to write:

incorrect

match path=(n:player{name: "Tim Duncan"})-[e:follow*1..2]-(m) \
    where e.degree > 0 \
    return path

rather than:

correct

match path=(n:player{name: "Tim Duncan"})-[e:follow*1..2]-(m) \
    where ALL(e_ in e WHERE e_.degree > 0) \
    return path

Could we put the correct expression somewhere(and in a highlighted way) in docs?

@wey-gu wey-gu changed the title Highlight somewhere in docs on property filter in bulk condition Highlight somewhere in docs on property filter in bulk pattern's condition Aug 12, 2021
@whitewum
Copy link
Contributor

it's about syntax, not semantics. the examples are tested and works for nebula 2.0.
but if you consider the example necessary, you can add one more example pr to the doc.

@wey-gu
Copy link
Contributor Author

wey-gu commented Sep 30, 2021

I will do this later, or maybe we could introduce a chapter like a query cheatsheet/ cookbook to include some typical/worth-highlighted query examples?

@abby-cyber
Copy link
Contributor

https://docs.nebula-graph.com.cn/2.6.0/2.quick-start/6.cheatsheet-for-ngql-command/

cheatsheet for nGQL

@wey-gu
Copy link
Contributor Author

wey-gu commented Nov 25, 2021

People still fall into this trap today

https://discuss.nebula-graph.com.cn/t/topic/6625/2

@wey-gu
Copy link
Contributor Author

wey-gu commented Nov 25, 2021

#1266 is trying to help with this trap

Allow me to reopen it

  • lift to en docs

@wey-gu wey-gu reopened this Nov 25, 2021
@wey-gu
Copy link
Contributor Author

wey-gu commented Nov 25, 2021

https://docs.nebula-graph.com.cn/2.6.0/2.quick-start/6.cheatsheet-for-ngql-command/

cheatsheet for nGQL

Thank you @abby-cyber , I didnt see this cause highlighted in cheatsheet, could we also have this trap highlighted in one of match examples in the cheatsheet?

wey-gu added a commit that referenced this issue Nov 25, 2021
whitewum pushed a commit that referenced this issue Nov 25, 2021
* highlight on bulk edge where filtering expression

close #824

* Fix Joe's comments
@abby-cyber
Copy link
Contributor

https://docs.nebula-graph.com.cn/2.6.0/2.quick-start/6.cheatsheet-for-ngql-command/
cheatsheet for nGQL

Thank you @abby-cyber , I didnt see this cause highlighted in cheatsheet, could we also have this trap highlighted in one of match examples in the cheatsheet?

already added desc for that trap. thank your for your reminding!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants