-
Notifications
You must be signed in to change notification settings - Fork 37
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good!
We should count the physical memory usage, not include buffer. Here More information refer to https://stackoverflow.com/questions/63166/how-to-determine-cpu-and-memory-consumption-from-inside-a-process |
Could have discuss later. Some known issues when I write data by importer:
If take buffer into consideration, it will solve these problems. |
Good point for question 1. Now you can update this config to In query engine, we have ignored the checks for most executors except query related executors and if |
Total = Used + Free + Buffer/Cache
Maybe need to take buffer/cache into consideration, here a screenshot when I do some test.
Graph will keep logging something like
Used memory(211303932KB) hits the high watermark(0.800000) of total system memory(263856036KB).
.PR is still in verification.