fix: fixes #311 - disable cgo in release builds #321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were getting the following error on el7: $ ./versitygw -h ./versitygw: /lib64/libc.so.6: version `GLIBC_2.32' not found (required by ./versitygw) ./versitygw: /lib64/libc.so.6: version `GLIBC_2.34' not found (required by ./versitygw) The temporary fix is to disable cgo in the builds per this issue: golang/go#58550 We will need to visit per distro builds once we need to re-enable cgo.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were getting the following error on el7:
$ ./versitygw -h
./versitygw: /lib64/libc.so.6: version
GLIBC_2.32' not found (required by ./versitygw) ./versitygw: /lib64/libc.so.6: versionGLIBC_2.34' not found (required by ./versitygw)The temporary fix is to disable cgo in the builds per this issue: golang/go#58550
We will need to visit per distro builds once we need to re-enable cgo.