fix: do not clean temporary files of the shell which is running.

[jan-bar]

fix: #283

A running terminal's temporary directory should never be deleted

[aooohan]

Looks great. Just the library hasn't been updated in a while.

[jan-bar]

Looks great. Just the library hasn't been updated in a while.

After a cursory look at the function of this library, it should be fine, but it is indeed a bit old.

This library is very new, but it has many dependencies and many unused functions.

https://github.com/shirou/gopsutil/blob/89124453c119ce42076b8c0ad84a6c50509776af/process/process.go#L182

[aooohan]

Looks great. Just the library hasn't been updated in a while.

After a cursory look at the function of this library, it should be fine, but it is indeed a bit old.

Actually, we can implement it ourselves, and both libraries are a bit complicated.

For Windows, we can refer the following code:

vfox/internal/shell/windows_process.go

Lines 36 to 44 in 2d15fc8

	func (w windowsProcess) Open(pid int) error {
	// On Windows, os.FindProcess does not actually find the process.
	// So, we use this workaround to get the parent process name.
	cmd := exec.Command("tasklist", "/FI", fmt.Sprintf("PID eq %d", pid), "/NH", "/FO", "CSV")
	output, err := cmd.Output()
	if err != nil {
	return err
	}
	cmd = exec.Command("wmic", "process", "where", fmt.Sprintf("ProcessId=%d", pid), "get", "ExecutablePath", "/format:list")

For Unix-like, we can directly use os.FindProcess function.

[jan-bar]

For Unix-like, we can directly use os.FindProcess function.

os.FindProcess always returns success under Linux, so it needs to be written as follows

package main

import (
	"flag"
	"os"
	"syscall"
)

func main() {
	pid := flag.Int("p", 0, "")
	flag.Parse()

	err := ProcessIsRun(*pid)
	if err != nil {
		panic(err)
	}
}

func ProcessIsRun(pid int) error {
	proc, err := os.FindProcess(pid)
	if err != nil {
		return err
	}
	defer proc.Release()
	return proc.Signal(syscall.Signal(0))
}

window does not support

Processes created by other users cannot be viewed under Linux. If you only consider cleaning up temporary files generated by the current user, there is no problem in doing so.

It is impossible to predict whether this scheme will behave correctly on different platforms.

In addition, the above two libraries do not use os.FindProcess when querying process information. There should be a reason.

[aooohan]

Okay. We can merge this now.