Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature]: Add a new hook PreUninstall for plugins. #208

Closed
aooohan opened this issue Apr 16, 2024 · 1 comment · Fixed by #223
Closed

[Feature]: Add a new hook PreUninstall for plugins. #208

aooohan opened this issue Apr 16, 2024 · 1 comment · Fixed by #223
Labels
enhancement New feature or request
Milestone
0.4.0

Comments

@aooohan
Copy link
Member

aooohan commented Apr 16, 2024 •
edited
Loading

1. Your usage scenarios?

Some plugins need to clean up some stuff before uninstalling the targeted runtime, e.g. python, after installing through the exe installer on Windows, will register some KEYs in the registry, when uninstalling, we need to clean up the corresponding KEYs in time.

2. What is your expected outcome?

Add a new hook PreUninstall for plugins.
@aooohan aooohan added the enhancement New feature or request label Apr 16, 2024
@aooohan aooohan added this to the 0.4.0 milestone Apr 16, 2024
@aooohan
Copy link
Member Author

aooohan commented Apr 16, 2024

aooohan added a commit that referenced this issue Apr 22, 2024
@aooohan
feat: add a new hook PreUninstall
adf1767 
This is called before the SDK is uninstalled. If the plugin needs to perform some operations before
uninstalling, it can implement this hook function. For example, cleaning up the cache, deleting configuration files, etc.

fix #208
@aooohan aooohan mentioned this issue Apr 22, 2024
Merged
aooohan added a commit that referenced this issue Apr 22, 2024
@aooohan
feat: add a new hook PreUninstall (#223)
a342c26 
* tmp

* feat: add a new hook `PreUninstall`

This is called before the SDK is uninstalled. If the plugin needs to perform some operations before
uninstalling, it can implement this hook function. For example, cleaning up the cache, deleting configuration files, etc.

fix #208
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
0.4.0
Development

Successfully merging a pull request may close this issue.

feat: add a new hook PreUninstall version-fox/vfox
1 participant
@aooohan