-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: CSS variables should allow simple HEX value #89
fix: CSS variables should allow simple HEX value #89
Conversation
WalkthroughThe changes across the files reflect a shift towards more dynamic and conditional styling in a UI component library. The Changes
TipsChat with CodeRabbit Bot (
|
BundleMonFiles updated (2)
Unchanged files (1)
Total files change -35B -0.35% Final result: ✅ View report in BundleMon website ➡️ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 1
Configuration used: .coderabbit.yaml
Files selected for processing (3)
- packages/ui-components/lib/twPlugin.js (3 hunks)
- packages/ui-components/src/components/Button/tests/Button.test.tsx (2 hunks)
- packages/ui-components/src/components/Button/utilities.ts (1 hunks)
Additional comments: 4
packages/ui-components/lib/twPlugin.js (1)
- 52-57: The removal of specific border classes is noted. Ensure that this change aligns with the intended design and that no other parts of the codebase rely on these classes.
packages/ui-components/src/components/Button/__tests__/Button.test.tsx (2)
33-37: The test has been updated to reflect the changes in the border class naming convention. Ensure that the actual implementation of the Button component matches these test expectations.
112-117: The new test case for a button with no borders is correctly checking for the absence of the "border-border-dark" class and the presence of the "border-transparent" class. This aligns with the changes made to the Button component's styling logic.
packages/ui-components/src/components/Button/utilities.ts (1)
- 89-95: The refactoring of
getButtonBorderClasses
usingclsx
for conditional class application is correct and improves maintainability. Ensure that thekind
parameter values align with the expected class naming conventions throughout the application.
Summary by CodeRabbit
Style
Tests
Refactor