fix(Flexgrid): margins are not taken into account in className prop #838
+11
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bundle Size (components)
Overall bundle size: 96.93 KB (+1 B 0.00%) Bundle Size (fingerprint)
Overall bundle size: 60.57 KB (+1 B 0.00%) Bundle Size (form components)
Overall bundle size: 66.22 KB (+1 B 0.00%) |
aversini
deleted the
fix(Flexgrid)-margins-are-not-taken-into-account-in-className-prop
branch
Merged
aversini
added a commit
that referenced
this pull request
Dec 29, 2024
🚀 Automated Release --- <details><summary>ui-system: 2.0.1</summary> ## [2.0.1](ui-system-v2.0.0...ui-system-v2.0.1) (2024-12-29) ### Bug Fixes * **Flexgrid:** margins are not taken into account in className prop ([#838](#838)) ([9a5ab9a](9a5ab9a)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes changes to the
Flexgridcomponent and its associated tests to improve the handling of class names and ensure proper styling.Changes to
Flexgridcomponent:packages/ui-system/src/components/Flexgrid/Flexgrid.tsx: Modified the component to wrap theflexgridClassNamediv with an additionaldivwhenclassNameis provided, ensuring that the custom class name is applied correctly.Changes to
Flexgridtests:packages/ui-system/src/components/Flexgrid/__tests__/Flexgrid.test.tsx: Updated the test to check the parent element for the class name, ensuring that the custom class name is applied to the correct element.