-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Card): adding prop "compact" #463
Conversation
WalkthroughThe recent update introduces a Changes
TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
Bundle Size (components)
Overall bundle size: 80.26 KB (+21 B +0.03%) Bundle Size (form components)
Overall bundle size: 49.23 KB (+8 B +0.02%) Bundle Size (system)
Overall bundle size: 53.48 KB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review Status
Configuration used: .coderabbit.yaml
Files selected for processing (5)
- packages/documentation/src/Components/Card.stories.tsx (2 hunks)
- packages/ui-components/src/components/Card/Card.tsx (2 hunks)
- packages/ui-components/src/components/Card/CardTypes.d.ts (2 hunks)
- packages/ui-components/src/components/Card/tests/Card.test.tsx (2 hunks)
- packages/ui-components/src/components/Card/utilities.ts (2 hunks)
Additional comments not posted (6)
packages/ui-components/src/components/Card/CardTypes.d.ts (1)
24-24
: Consider adding documentation for thecompact
property to explain its effect on theCard
component.packages/documentation/src/Components/Card.stories.tsx (2)
11-11
: The addition of thecompact
property with a default value offalse
is correctly implemented.
67-67
: Changing the header element from<h3>
to<h2>
in theCustom
component is a good practice for semantic HTML and accessibility.packages/ui-components/src/components/Card/utilities.ts (1)
10-10
: The addition of thecompact
parameter to thegetCardClasses
function is correctly implemented for dynamic styling adjustments.packages/ui-components/src/components/Card/Card.tsx (1)
42-42
: The addition of thecompact
prop with a default value offalse
is correctly implemented and used effectively within the component.packages/ui-components/src/components/Card/__tests__/Card.test.tsx (1)
78-93
: The new test case for rendering a default compact card is correctly implemented, ensuring the feature's functionality is preserved across updates.
🤖 I have created a release *beep* *boop* --- <details><summary>ui-components: 5.12.0</summary> ## [5.12.0](ui-components-v5.11.1...ui-components-v5.12.0) (2024-04-06) ### Features * **Card:** adding prop "compact" ([#463](#463)) ([1f65900](1f65900)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: aversini <[email protected]>
Summary by CodeRabbit
compact
option for Card components to allow for smaller card rendering.<h3>
to<h2>
.compact
feature in Card components.