Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: reducing time to deploy but limiting build scope #431

Merged

Conversation

aversini
Copy link
Collaborator

@aversini aversini commented Mar 18, 2024

Summary by CodeRabbit

  • Chores
    • Updated the deployment workflow to exclude certain packages from the build process, enhancing efficiency.

Copy link

coderabbitai bot commented Mar 18, 2024

Walkthrough

The modification focuses on altering the build command within a GitHub Actions workflow. It specifically aims to streamline the build process by excluding certain packages from being built. This exclusion targets packages with names starting with @versini/example-, along with @versini/documentation and @versini/bundlesize, making the build process more efficient by omitting these specific components.

Changes

File Path Change Summary
.github/workflows/deploy-pages.yml Modified the build command to exclude @versini/example-*, @versini/documentation, and @versini/bundlesize packages from the build process.

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

Copy link

Bundle Size (components)

Status File Size (Gzip) Limits
style.css 6.63 KB (+5 B +0.07%) 8 KB
index.js 8.04 KB (+4 B +0.05%) 20 KB
vendor.js 65.07 KB 67 KB

Overall bundle size: 79.73 KB (+9 B +0.01%)
Overall status: ✅

Bundle Size (form components)

Status File Size (Gzip) Limits
index.js 4.73 KB (+5 B +0.10%) 20 KB
vendor.js 44.49 KB 67 KB

Overall bundle size: 49.22 KB (+5 B +0.01%)
Overall status: ✅

Bundle Size (system)

Status File Size (Gzip) Limits
style.css 6.96 KB (+269 B +3.92%) 8 KB
index.js 1.74 KB (+1 B +0.06%) 3 KB
vendor.js 44.49 KB 46 KB

Overall bundle size: 53.19 KB (+270 B +0.50%)
Overall status: ✅

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: .coderabbit.yaml

Commits Files that changed from the base of the PR and between 7d22f0b and 172feb7.
Files selected for processing (1)
  • .github/workflows/deploy-pages.yml (1 hunks)
Additional comments: 1
.github/workflows/deploy-pages.yml (1)
  • 42-42: The optimization by excluding specific packages (@versini/example-*, @versini/documentation, and @versini/bundlesize) from the build process is a strategic approach to streamline deployments. However, it's followed by a targeted build command for the @versini/documentation package. Ensure that this two-step build process indeed contributes to the overall efficiency of the deployment, and consider measuring the deployment time before and after this change to verify its impact.

@aversini aversini merged commit cd3b212 into main Mar 18, 2024
5 checks passed
@aversini aversini deleted the chore-reducing-time-to-deploy-but-limiting-build-scope branch March 18, 2024 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant