Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui-icons): removing redundant dependencies and adding them to the plugin #392

Merged
merged 3 commits into from
Mar 10, 2024
Merged

fix(ui-icons): removing redundant dependencies and adding them to the plugin #392

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5f901c1
fix(ui-icons): removing redundant dependencies and adding them to the…
aversini Mar 10, 2024
eb63890
Update tailwindPlugin.test.ts
aversini Mar 10, 2024
d69608d
re-adding ui-private
aversini Mar 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 1 addition & 8 deletions packages/ui-icons/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,14 +39,7 @@
"react-dom": "^18.2.0"
},
"devDependencies": {
"@versini/ui-plugins": "workspace:../ui-plugins"
},
"dependencies": {
"@tailwindcss/typography": "0.5.10",
"@versini/ui-hooks": ">=2.1.1",
"@versini/ui-private": "workspace:../ui-private",
"clsx": "2.1.0",
"tailwindcss": "3.4.1"
"@versini/ui-private": "workspace:../ui-private"
},
"sideEffects": [
"**/*.css"
Expand Down
7 changes: 0 additions & 7 deletions packages/ui-icons/postcss.config.cjs
View file
Open in desktop

This file was deleted.

2 changes: 1 addition & 1 deletion packages/ui-icons/src/components/Icons/IconDog.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ export const IconDog = ({
return (
<SvgIcon
defaultViewBox="0 0 1200 500"
defaultClassName={"w-full"}
defaultClassName="w-full"
viewBox={viewBox}
className={className}
spacing={spacing}
Expand Down
3 changes: 0 additions & 3 deletions packages/ui-icons/src/index.css
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion packages/ui-icons/src/style.ts
View file
Open in desktop

This file was deleted.

7 changes: 0 additions & 7 deletions packages/ui-icons/tailwind.config.js
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion packages/ui-icons/vite.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,6 @@ export default defineConfig(({ mode }) => {
rollupOptions: {
input: {
index: resolve(__dirname, "src/components/index.ts"),
style: resolve(__dirname, "src/style.ts"),
...input,
},
treeshake: "smallest",
Expand Down
5 changes: 3 additions & 2 deletions packages/ui-plugins/src/plugins/__tests__/tailwindPlugin.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,10 @@ import { customContentPath } from "../tailwindcss/tailwindPlugin";

describe("Non-DOM tests", () => {
it("should return an array with ui-system and ui-components", () => {
expect(customContentPath[0]).toContain("node_modules/@versini/ui-system");
expect(customContentPath[1]).toContain(
expect(customContentPath[0]).toContain(
"node_modules/@versini/ui-components",
);
expect(customContentPath[1]).toContain("node_modules/@versini/ui-icons");
expect(customContentPath[2]).toContain("node_modules/@versini/ui-system");
});
});
3 changes: 2 additions & 1 deletion packages/ui-plugins/src/plugins/tailwindcss/tailwindPlugin.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,9 @@ type TailwindConfig = {
* added here.
*/
export const customContentPath = [
"@versini/ui-system",
"@versini/ui-components",
"@versini/ui-icons",
"@versini/ui-system",
].map(
(pkg) => `${process.cwd()}/node_modules/${pkg}/dist/**/*.{js,ts,jsx,tsx}`,
);
Expand Down
21 changes: 3 additions & 18 deletions pnpm-lock.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading