-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ui-plugins): incorrect node_modules path leading to invalid styles #379
fix(ui-plugins): incorrect node_modules path leading to invalid styles #379
Conversation
WalkthroughThe recent update focuses on refining the way specific packages are referenced within a project. Specifically, it enhances the identification and handling of Changes
TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
Bundle Size (components)
Overall bundle size: 86.67 KB (+4 B 0.00%) Bundle Size (system)
Overall bundle size: 53.73 KB (+2 B 0.00%) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 0
Configuration used: .coderabbit.yaml
Files selected for processing (2)
- packages/ui-plugins/src/plugins/tests/tailwindPlugin.test.ts (1 hunks)
- packages/ui-plugins/src/plugins/tailwindPlugin.ts (1 hunks)
Additional comments: 2
packages/ui-plugins/src/plugins/__tests__/tailwindPlugin.test.ts (1)
- 7-10: The update to the test paths is a good improvement, ensuring that the tests accurately reflect the actual dependency paths. This change aligns well with the PR objectives of correcting path references to ensure styles are correctly applied.
packages/ui-plugins/src/plugins/tailwindPlugin.ts (1)
- 15-20: The updates to the
packagesList
array and thetailwindContentPath
generation logic are well-implemented. Including scoped package names and usingprocess.cwd()
for dynamic path generation are effective solutions to the issue of incorrect path references. These changes ensure that the plugin accurately constructs paths to dependencies, addressing the core issue of invalid styles.
🤖 I have created a release *beep* *boop* --- <details><summary>ui-plugins: 1.1.2</summary> ## [1.1.2](ui-plugins-v1.1.1...ui-plugins-v1.1.2) (2024-03-08) ### Bug Fixes * **ui-plugins:** incorrect node_modules path leading to invalid styles ([#379](#379)) ([2dc2b3b](2dc2b3b)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Summary by CodeRabbit