Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui-plugins): incorrect node_modules path leading to invalid styles #379

Conversation

aversini
Copy link
Collaborator

@aversini aversini commented Mar 8, 2024

Summary by CodeRabbit

  • Refactor
    • Improved the tailwind plugin's compatibility with scoped packages in our UI system, enhancing the accuracy of style generation.

Copy link

coderabbitai bot commented Mar 8, 2024

Walkthrough

The recent update focuses on refining the way specific packages are referenced within a project. Specifically, it enhances the identification and handling of @versini/ui-system and @versini/ui-components packages in both testing and functionality. The changes ensure that these scoped package names are accurately included in paths for better specificity and clarity, optimizing the project's interaction with Tailwind CSS configurations.

Changes

File Path Change Summary
.../__tests__/tailwindPlugin.test.ts Updated test cases to check for paths containing node_modules/@versini/ui-system and node_modules/@versini/ui-components.
.../plugins/tailwindPlugin.ts Modified packagesList to include scoped package names and updated tailwindContentPath generation to incorporate these names in path construction.

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

Copy link

github-actions bot commented Mar 8, 2024

Bundle Size (components)

Status File Size (Gzip) Limits
style.css 7.17 KB 8 KB
index.js 14.44 KB (+4 B +0.03%) 20 KB
vendor.js 65.07 KB 67 KB

Overall bundle size: 86.67 KB (+4 B 0.00%)
Overall status: ✅

Bundle Size (system)

Status File Size (Gzip) Limits
style.css 7.5 KB 8 KB
index.js 1.74 KB (+2 B +0.11%) 3 KB
vendor.js 44.49 KB 46 KB

Overall bundle size: 53.73 KB (+2 B 0.00%)
Overall status: ✅

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: .coderabbit.yaml

Commits Files that changed from the base of the PR and between efe2bd9 and 936f218.
Files selected for processing (2)
  • packages/ui-plugins/src/plugins/tests/tailwindPlugin.test.ts (1 hunks)
  • packages/ui-plugins/src/plugins/tailwindPlugin.ts (1 hunks)
Additional comments: 2
packages/ui-plugins/src/plugins/__tests__/tailwindPlugin.test.ts (1)
  • 7-10: The update to the test paths is a good improvement, ensuring that the tests accurately reflect the actual dependency paths. This change aligns well with the PR objectives of correcting path references to ensure styles are correctly applied.
packages/ui-plugins/src/plugins/tailwindPlugin.ts (1)
  • 15-20: The updates to the packagesList array and the tailwindContentPath generation logic are well-implemented. Including scoped package names and using process.cwd() for dynamic path generation are effective solutions to the issue of incorrect path references. These changes ensure that the plugin accurately constructs paths to dependencies, addressing the core issue of invalid styles.

@aversini aversini merged commit 2dc2b3b into main Mar 8, 2024
5 checks passed
@aversini aversini deleted the fix(ui-plugins)-incorrect-node_modules-path-leading-to-invalid-styles branch March 8, 2024 14:56
@aversini aversini mentioned this pull request Mar 8, 2024
aversini added a commit that referenced this pull request Mar 8, 2024
🤖 I have created a release *beep* *boop*
---


<details><summary>ui-plugins: 1.1.2</summary>

##
[1.1.2](ui-plugins-v1.1.1...ui-plugins-v1.1.2)
(2024-03-08)


### Bug Fixes

* **ui-plugins:** incorrect node_modules path leading to invalid styles
([#379](#379))
([2dc2b3b](2dc2b3b))
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant