Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Icons): adding IconBrightness #367

Merged
merged 1 commit into from
Feb 28, 2024
Merged

Conversation

aversini
Copy link
Collaborator

@aversini aversini commented Feb 28, 2024

Summary by CodeRabbit

  • New Features
    • Added a new "Brightness" icon with dual-tone styling and functionality to adjust opacity for a more intuitive brightness control experience.

Copy link

coderabbitai bot commented Feb 28, 2024

Walkthrough

The update introduces a new "Brightness" icon to the UI icons library, featuring dual-tone styling but with an option for monotone rendering. This addition encompasses the icon's configuration, SVG file, a React component for the icon with conditional opacity, and updates to tests and exports to integrate the new icon into the library seamlessly.

Changes

File Path Change Summary
.../ui-icons/lib/icons/config.json Added configuration for "Brightness" icon with monotone property.
.../ui-icons/lib/icons/svg/brightness.svg Added SVG file for brightness icon with dual-tone styling.
.../ui-icons/src/components/Icons/IconBrightness.tsx Added SVG icon component for brightness with monotone opacity adjustment.
.../ui-icons/src/components/Icons/__tests__/Icons.test.tsx Updated tests to include the new IconBrightness component.
.../ui-icons/src/components/index.ts Added export for IconBrightness component.

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository from git and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

Copy link

Bundle Size (components)

Status File Size (Gzip) Limits
style.css 7.12 KB 8 KB
index.js 16.23 KB (+7 B +0.04%) 20 KB
vendor.js 65.07 KB 67 KB

Overall bundle size: 88.41 KB (+7 B +0.01%)
Overall status: ✅

Bundle Size (system)

Status File Size (Gzip) Limits
style.css 2.83 KB 4 KB
index.js 1.74 KB 3 KB
vendor.js 44.49 KB 46 KB

Overall bundle size: 49.06 KB
Overall status: ✅

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: .coderabbit.yaml

Commits Files that changed from the base of the PR and between f9f9abd and ddc4260.
Files selected for processing (5)
  • packages/ui-icons/lib/icons/config.json (1 hunks)
  • packages/ui-icons/lib/icons/svg/brightness.svg (1 hunks)
  • packages/ui-icons/src/components/Icons/IconBrightness.tsx (1 hunks)
  • packages/ui-icons/src/components/Icons/tests/Icons.test.tsx (3 hunks)
  • packages/ui-icons/src/components/index.ts (2 hunks)
Files skipped from review due to trivial changes (2)
  • packages/ui-icons/lib/icons/svg/brightness.svg
  • packages/ui-icons/src/components/Icons/IconBrightness.tsx
Additional comments: 3
packages/ui-icons/src/components/index.ts (1)
  • 2-2: The addition of IconBrightness to both imports and exports is correctly implemented and follows the established pattern in the file. This change effectively integrates the new icon into the library's exports, making it available for use.

Also applies to: 24-24

packages/ui-icons/lib/icons/config.json (1)
  • 85-88: The addition of the "Brightness" icon configuration with the monotone property set to true is correctly implemented. This change aligns with the PR's objectives and follows the established JSON structure for icon configurations.
packages/ui-icons/src/components/Icons/__tests__/Icons.test.tsx (1)
  • 6-6: The addition of IconBrightness to the imports and its inclusion in the unit tests are correctly implemented. These changes ensure that the new icon is thoroughly tested, maintaining the library's quality and reliability. The implementation follows the established patterns and correctly integrates the new icon into the testing process.

Also applies to: 197-203, 226-226

@aversini aversini merged commit 68afee2 into main Feb 28, 2024
6 checks passed
@aversini aversini deleted the feat(Icons)-adding-IconBrightness branch February 28, 2024 21:44
@aversini aversini mentioned this pull request Feb 28, 2024
aversini added a commit that referenced this pull request Feb 28, 2024
🤖 I have created a release *beep* *boop*
---


<details><summary>ui-icons: 1.1.0</summary>

##
[1.1.0](ui-icons-v1.0.0...ui-icons-v1.1.0)
(2024-02-28)


### Features

* **Icons:** adding IconBrightness
([#367](#367))
([68afee2](68afee2))
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant