-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Icons): adding IconBrightness #367
Conversation
WalkthroughThe update introduces a new "Brightness" icon to the UI icons library, featuring dual-tone styling but with an option for monotone rendering. This addition encompasses the icon's configuration, SVG file, a React component for the icon with conditional opacity, and updates to tests and exports to integrate the new icon into the library seamlessly. Changes
TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
Bundle Size (components)
Overall bundle size: 88.41 KB (+7 B +0.01%) Bundle Size (system)
Overall bundle size: 49.06 KB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 0
Configuration used: .coderabbit.yaml
Files selected for processing (5)
- packages/ui-icons/lib/icons/config.json (1 hunks)
- packages/ui-icons/lib/icons/svg/brightness.svg (1 hunks)
- packages/ui-icons/src/components/Icons/IconBrightness.tsx (1 hunks)
- packages/ui-icons/src/components/Icons/tests/Icons.test.tsx (3 hunks)
- packages/ui-icons/src/components/index.ts (2 hunks)
Files skipped from review due to trivial changes (2)
- packages/ui-icons/lib/icons/svg/brightness.svg
- packages/ui-icons/src/components/Icons/IconBrightness.tsx
Additional comments: 3
packages/ui-icons/src/components/index.ts (1)
- 2-2: The addition of
IconBrightness
to both imports and exports is correctly implemented and follows the established pattern in the file. This change effectively integrates the new icon into the library's exports, making it available for use.Also applies to: 24-24
packages/ui-icons/lib/icons/config.json (1)
- 85-88: The addition of the "Brightness" icon configuration with the
monotone
property set totrue
is correctly implemented. This change aligns with the PR's objectives and follows the established JSON structure for icon configurations.packages/ui-icons/src/components/Icons/__tests__/Icons.test.tsx (1)
- 6-6: The addition of
IconBrightness
to the imports and its inclusion in the unit tests are correctly implemented. These changes ensure that the new icon is thoroughly tested, maintaining the library's quality and reliability. The implementation follows the established patterns and correctly integrates the new icon into the testing process.Also applies to: 197-203, 226-226
🤖 I have created a release *beep* *boop* --- <details><summary>ui-icons: 1.1.0</summary> ## [1.1.0](ui-icons-v1.0.0...ui-icons-v1.1.0) (2024-02-28) ### Features * **Icons:** adding IconBrightness ([#367](#367)) ([68afee2](68afee2)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Summary by CodeRabbit