Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: adding spacing prop to icons #28

Merged
merged 4 commits into from
Nov 8, 2023
Merged

Feat: adding spacing prop to icons #28

merged 4 commits into from
Nov 8, 2023

Conversation

aversini
Copy link
Collaborator

@aversini aversini commented Nov 8, 2023

No description provided.

@coderabbitai coderabbitai
Copy link

coderabbitai bot commented Nov 8, 2023 •
edited
Loading

Tips

Chat with CodeRabbit Bot (@coderabbitai)

  • If you reply to a review comment from CodeRabbit, the bot will automatically respond.
  • To engage with CodeRabbit bot directly around the specific lines of code in the PR, mention @coderabbitai in your review comment
  • Note: Review comments are made on code diffs or files, not on the PR overview.
  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai help to get help.
  • @coderabbitai resolve to resolve all the CodeRabbit review comments.

Note: For conversation with the bot, please use the review comments on code diffs or files.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

@bundlemon BundleMon
Copy link

bundlemon bot commented Nov 8, 2023

BundleMon

Files updated (1)
Status Path Size Limits
✅ assets/index-(hash).js
 48.79KB (+122B +0.24%) 60KB
Unchanged files (2)
Status Path Size Limits
✅ assets/index-(hash).css
 2.2KB 3KB
✅ index.html
 433B 2KB

Total files change +122B +0.23%

Final result: ✅

View report in BundleMon website ➡️

Current branch size history | Target branch size history

@aversini aversini merged commit 224f921 into main Nov 8, 2023
5 checks passed
@aversini aversini deleted the feat-adding-spacing-prop-to-Icons branch November 8, 2023 15:22
coderabbitai[bot]
coderabbitai bot reviewed Nov 8, 2023
View reviewed changes
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: .coderabbit.yaml

Commits Files that changed from the base of the PR and between b033cbe and 56e8a5c.
Files selected for processing (15)
  • packages/ui-components/src/components/Icons/IconClose.tsx (1 hunks)
  • packages/ui-components/src/components/Icons/IconCopied.tsx (1 hunks)
  • packages/ui-components/src/components/Icons/IconCopy.tsx (1 hunks)
  • packages/ui-components/src/components/Icons/IconDelete.tsx (1 hunks)
  • packages/ui-components/src/components/Icons/IconDog.tsx (1 hunks)
  • packages/ui-components/src/components/Icons/IconDogInShield.tsx (1 hunks)
  • packages/ui-components/src/components/Icons/IconEdit.tsx (1 hunks)
  • packages/ui-components/src/components/Icons/IconRestore.tsx (1 hunks)
  • packages/ui-components/src/components/Icons/IconSettings.tsx (1 hunks)
  • packages/ui-components/src/components/Icons/IconUser.tsx (1 hunks)
  • packages/ui-components/src/components/Icons/IconsTypes.d.ts (1 hunks)
  • packages/ui-components/src/components/Icons/tests/Icons.test.tsx (1 hunks)
  • packages/ui-components/src/components/private/SvgIcon/SvgIcon.tsx (2 hunks)
  • packages/ui-components/src/components/private/SvgIcon/SvgIconTypes.d.ts (2 hunks)
  • packages/ui-components/vitest.config.ts (1 hunks)
Files not summarized due to errors (15)
  • packages/ui-components/src/components/Icons/IconDogInShield.tsx: Error: Server error. Please try again later.
  • packages/ui-components/src/components/private/SvgIcon/SvgIconTypes.d.ts: Error: Server error. Please try again later.
  • packages/ui-components/src/components/Icons/IconSettings.tsx: Error: Server error. Please try again later.
  • packages/ui-components/src/components/Icons/IconEdit.tsx: Error: Server error. Please try again later.
  • packages/ui-components/src/components/Icons/IconClose.tsx: Error: Server error. Please try again later.
  • packages/ui-components/src/components/private/SvgIcon/SvgIcon.tsx: Error: Server error. Please try again later.
  • packages/ui-components/src/components/Icons/tests/Icons.test.tsx: Error: Server error. Please try again later.
  • packages/ui-components/src/components/Icons/IconUser.tsx: Error: Server error. Please try again later.
  • packages/ui-components/src/components/Icons/IconDelete.tsx: Error: Server error. Please try again later.
  • packages/ui-components/src/components/Icons/IconCopy.tsx: Error: Server error. Please try again later.
  • packages/ui-components/src/components/Icons/IconRestore.tsx: Error: Server error. Please try again later.
  • packages/ui-components/src/components/Icons/IconCopied.tsx: Error: Server error. Please try again later.
  • packages/ui-components/src/components/Icons/IconDog.tsx: Error: Server error. Please try again later.
  • packages/ui-components/vitest.config.ts: Error: Server error. Please try again later.
  • packages/ui-components/src/components/Icons/IconsTypes.d.ts: Error: Server error. Please try again later.
Files not reviewed due to errors (15)
  • packages/ui-components/src/components/Icons/IconsTypes.d.ts (Error: Server error. Please try again later.)
  • packages/ui-components/src/components/Icons/IconUser.tsx (Error: Server error. Please try again later.)
  • packages/ui-components/src/components/Icons/IconRestore.tsx (Error: Server error. Please try again later.)
  • packages/ui-components/src/components/Icons/IconDog.tsx (Error: Server error. Please try again later.)
  • packages/ui-components/src/components/Icons/IconSettings.tsx (Error: Server error. Please try again later.)
  • packages/ui-components/src/components/private/SvgIcon/SvgIconTypes.d.ts (Error: Server error. Please try again later.)
  • packages/ui-components/src/components/Icons/IconCopy.tsx (Error: Server error. Please try again later.)
  • packages/ui-components/src/components/Icons/tests/Icons.test.tsx (Error: Server error. Please try again later.)
  • packages/ui-components/src/components/Icons/IconEdit.tsx (Error: Server error. Please try again later.)
  • packages/ui-components/src/components/Icons/IconDelete.tsx (Error: Server error. Please try again later.)
  • packages/ui-components/vitest.config.ts (Error: Server error. Please try again later.)
  • packages/ui-components/src/components/Icons/IconClose.tsx (Error: Server error. Please try again later.)
  • packages/ui-components/src/components/Icons/IconCopied.tsx (Error: Server error. Please try again later.)
  • packages/ui-components/src/components/Icons/IconDogInShield.tsx (Error: Server error. Please try again later.)
  • packages/ui-components/src/components/private/SvgIcon/SvgIcon.tsx (Error: Server error. Please try again later.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@aversini