Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add noPadding prop to Footer #15

Merged
merged 1 commit into from
Nov 6, 2023

Conversation

aversini
Copy link
Collaborator

@aversini aversini commented Nov 6, 2023

Summary by CodeRabbit

  • New Features
    • Introduced an option to control the presence of bottom margin in the footer component.
    • Added a new optional property to the footer component to control padding application.

Copy link

coderabbitai bot commented Nov 6, 2023

Walkthrough

The recent changes primarily focus on enhancing the Footer component in the UI package. A new prop noPaddings has been introduced, allowing developers to control the application of bottom margin in the footer. This prop is optional and defaults to false.

Changes

File Path Change Summary
.../Footer/Footer.tsx Added noPaddings prop to control bottom margin. Default value is false.
.../Footer/FooterTypes.d.ts Updated FooterProps interface to include optional noPaddings property.

Poem

🐇 Hopping through the code, a change we've sowed, 🌱

In the season of fall, we stand tall, 🍂

A tweak in the Footer, as light as a flutter, 🦋

Now control the padding, isn't that madding? 🎉

On this day in history, a change without mystery, 🔍

Celebrate we must, in code we trust! 🎈


Tips

Chat with CodeRabbit Bot (@coderabbitai)

  • If you reply to a review comment from CodeRabbit, the bot will automatically respond.
  • To engage with CodeRabbit bot directly around the specific lines of code in the PR, mention @coderabbitai in your review comment
  • Note: Review comments are made on code diffs or files, not on the PR overview.
  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai help to get help.
  • @coderabbitai resolve to resolve all the CodeRabbit review comments.

Note: For conversation with the bot, please use the review comments on code diffs or files.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between cdeb437 and 54e0515.
Files selected for processing (2)
  • packages/ui-components/src/components/Footer/Footer.tsx (1 hunks)
  • packages/ui-components/src/components/Footer/FooterTypes.d.ts (1 hunks)
Files skipped from review due to trivial changes (2)
  • packages/ui-components/src/components/Footer/Footer.tsx
  • packages/ui-components/src/components/Footer/FooterTypes.d.ts

Copy link

bundlemon bot commented Nov 6, 2023

BundleMon

Files updated (1)
Status Path Size Limits
assets/index-(hash).js
45.9KB (+15B +0.03%) 50KB
Unchanged files (2)
Status Path Size Limits
assets/index-(hash).css
2.06KB 3KB
index.html
434B 2KB

Total files change +15B +0.03%

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

@aversini aversini merged commit fc54e3c into main Nov 6, 2023
4 checks passed
@aversini aversini deleted the feat-add-noPadding-prop-to-Footer branch November 6, 2023 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant