Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adding sourcemaps to production builds #114

Merged
merged 1 commit into from
Dec 4, 2023

Conversation

aversini
Copy link
Collaborator

@aversini aversini commented Dec 4, 2023

Summary by CodeRabbit

  • Refactor
    • Improved debugging capabilities by enabling source map generation for the build process.
    • Modified build configuration to prevent copying of the public directory by default.

Copy link

coderabbitai bot commented Dec 4, 2023

Walkthrough

The configuration for a UI components package has been updated to include source map generation during the build process, enhancing debugging capabilities. Additionally, the default behavior of copying the public directory has been disabled, which may affect how public assets are managed during builds.

Changes

File Path Change Summary
packages/.../vite.config.ts Added sourcemap: true and set copyPublicDir to false in the build section.

Tips

Chat with CodeRabbit Bot (@coderabbitai)

  • If you reply to a review comment from CodeRabbit, the bot will automatically respond.
  • To engage with CodeRabbit bot directly around the specific lines of code in the PR, mention @coderabbitai in your review comment
  • Note: Review comments are made on code diffs or files, not on the PR overview.
  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Note: For conversation with the bot, please use the review comments on code diffs or files.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: .coderabbit.yaml

Commits Files that changed from the base of the PR and between 070a694 and 0076580.
Files selected for processing (1)
  • packages/ui-components/vite.config.ts (1 hunks)
Additional comments: 1
packages/ui-components/vite.config.ts (1)
  • 21-27: The changes to the vite.config.ts file correctly implement the PR objectives by enabling source maps for production builds and altering the handling of public assets. Ensure that the new handling of public assets is compatible with the deployment process and that all necessary assets are included in the production build.

Copy link

bundlemon bot commented Dec 4, 2023

BundleMon

Unchanged files (3)
Status Path Size Limits
assets/index.js
8.21KB 10KB
assets/style.css
3.51KB 4KB
index.html
318B 2KB

No change in files bundle size

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

@aversini aversini merged commit adac494 into main Dec 4, 2023
4 checks passed
@aversini aversini deleted the feat-adding-sourcemaps-to-production-builds branch December 4, 2023 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant