code review: moving extra props at the end

versini-org · Dec 2, 2023 · f216550 · f216550
1 parent 7964220
commit f216550
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 4 deletions.
diff --git a/packages/ui-components/src/components/Button/Button.tsx b/packages/ui-components/src/components/Button/Button.tsx
@@ -39,13 +39,13 @@ export const Button = React.forwardRef<HTMLButtonElement, ButtonProps>(
 
 		return (
 			<button
-				{...otherProps}
 				ref={ref}
 				className={buttonClass}
 				onClick={onClick}
 				disabled={disabled}
 				type={type}
 				aria-label={ariaLabel}
+				{...otherProps}
 			>
 				{children}
 			</button>

diff --git a/packages/ui-components/src/components/Button/ButtonIcon.tsx b/packages/ui-components/src/components/Button/ButtonIcon.tsx
@@ -39,13 +39,13 @@ export const ButtonIcon = React.forwardRef<HTMLButtonElement, ButtonIconProps>(
 		return (
 			<>
 				<button
-					{...otherProps}
 					ref={ref}
 					className={buttonClass}
 					onClick={onClick}
 					disabled={disabled}
 					type={type}
 					aria-label={ariaLabel || label}
+					{...otherProps}
 				>
 					{children}
 				</button>

diff --git a/packages/ui-components/src/components/TextInput/TextInput.tsx b/packages/ui-components/src/components/TextInput/TextInput.tsx
@@ -66,7 +66,6 @@ export const TextInput = React.forwardRef<HTMLInputElement, TextInputProps>(
 					{label}
 				</label>
 				<input
-					{...extraProps}
 					ref={ref}
 					id={inputId}
 					name={name}
@@ -78,6 +77,7 @@ export const TextInput = React.forwardRef<HTMLInputElement, TextInputProps>(
 					{...(error && { "aria-invalid": "true" })}
 					{...(rightElement &&
 						!raw && { style: { paddingRight: inputPaddingRight } })}
+					{...extraProps}
 				/>
 				{!raw && (
 					<label

diff --git a/packages/ui-components/src/components/TextInput/TextInputMask.tsx b/packages/ui-components/src/components/TextInput/TextInputMask.tsx
@@ -135,7 +135,6 @@ export const TextInputMask = React.forwardRef<
 		return (
 			<>
 				<TextInput
-					{...otherProps}
 					ref={mergedInputRef}
 					name={name}
 					label={label}
@@ -154,6 +153,7 @@ export const TextInputMask = React.forwardRef<
 							{masked ? <IconShow /> : <IconHide />}
 						</ButtonIcon>
 					}
+					{...otherProps}
 				/>
 
 				<LiveRegion