Skip to content

Commit

Permalink
Merge pull request #83 from aversini/fix(Button)-children-is-not-an-o…
Browse files Browse the repository at this point in the history
…ptional-prop

fix(Button): children is not an optional prop
  • Loading branch information
aversini authored Nov 26, 2023
2 parents 23383fe + 65860ac commit e37f273
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions packages/ui-components/src/components/Button/ButtonTypes.d.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
export type CommonButtonProps = {
children: React.ReactNode;
kind?: "dark" | "light";
focus?: "dark" | "light";
fullWidth?: boolean;
Expand All @@ -13,9 +14,8 @@ export type ButtonProps = {
type?: "button" | "submit" | "reset";
slim?: boolean;
size?: "small" | "medium" | "large";
} & CommonButtonProps & {
children?: React.ReactNode;
} & React.ButtonHTMLAttributes<HTMLButtonElement>;
} & CommonButtonProps &
React.ButtonHTMLAttributes<HTMLButtonElement>;

export type ButtonLinkProps = {
children?: React.ReactNode;
Expand Down

0 comments on commit e37f273

Please sign in to comment.