Skip to content

Commit

Permalink
fix: externalize Card types (#779)
Browse files Browse the repository at this point in the history
  • Loading branch information
aversini authored Dec 23, 2024
1 parent d5e9c9d commit e157db3
Show file tree
Hide file tree
Showing 7 changed files with 34 additions and 7 deletions.
1 change: 1 addition & 0 deletions .release-please-manifest.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
"packages/ui-bubble": "1.1.1",
"packages/ui-button": "1.2.1",
"packages/ui-card": "1.1.1",
"packages/ui-types/ui-card-types": "0.0.0",
"packages/ui-components": "5.32.1",
"packages/ui-fingerprint": "1.1.0",
"packages/ui-footer": "1.1.1",
Expand Down
9 changes: 3 additions & 6 deletions packages/ui-card/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,7 @@
"type": "module",
"main": "dist/index.js",
"types": "dist/index.d.ts",
"files": [
"dist"
],
"files": ["dist"],
"scripts": {
"build:check": "tsc",
"build:js": "vite build",
Expand All @@ -39,12 +37,11 @@
},
"dependencies": {
"@tailwindcss/typography": "0.5.15",
"@versini/ui-card-types": "workspace:../ui-types/ui-card-types",
"@versini/ui-hooks": "workspace:../ui-hooks",
"@versini/ui-private": "workspace:../ui-private",
"clsx": "2.1.1",
"tailwindcss": "3.4.17"
},
"sideEffects": [
"**/*.css"
]
"sideEffects": ["**/*.css"]
}
2 changes: 1 addition & 1 deletion packages/ui-card/src/components/Card/Card.tsx
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import type { CardHeaderProps, CardProps } from "@versini/ui-card-types";
import { useUniqueId } from "@versini/ui-hooks";

import { CARD_CLASSNAME } from "../../common/constants";
import type { CardHeaderProps, CardProps } from "./CardTypes";
import { getCardClasses } from "./utilities";

function CardHeader({
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import type { SpacingProps } from "@versini/ui-private/dist/utilities";
import React from "react";

export type CardProps = {
/**
Expand Down
18 changes: 18 additions & 0 deletions packages/ui-types/ui-card-types/package.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
{
"name": "@versini/ui-card-types",
"version": "0.0.0",
"license": "MIT",
"author": "Arno Versini",
"publishConfig": {
"access": "public"
},
"homepage": "https://github.com/aversini/ui-components",
"repository": {
"type": "git",
"url": "[email protected]:aversini/ui-components.git"
},
"types": "index.d.ts",
"dependencies": {
"@versini/ui-private": "workspace:../ui-private"
}
}
9 changes: 9 additions & 0 deletions pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions pnpm-workspace.yaml
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
packages:
- packages/*
- packages/ui-types/*
- examples/*

0 comments on commit e157db3

Please sign in to comment.