fix: on failed login, isLading is never reset (#89)

versini-org · Jul 9, 2024 · a8f52e7 · a8f52e7
1 parent 22bd7ad
commit a8f52e7
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 0 deletions.
diff --git a/examples/code-flow/src/main.tsx b/examples/code-flow/src/main.tsx
@@ -9,6 +9,8 @@ export const App = ({ timeout }: { timeout: string }) => {
 		useAuth();
 	const [apiResponse, setApiResponse] = useState({ data: "" });
 
+	console.info({ isAuthenticated, isLoading });
+
 	const logger = console;
 	logger.log("isAuthenticated", isAuthenticated);
 	logger.log("isLoading", isLoading);
@@ -32,6 +34,7 @@ export const App = ({ timeout }: { timeout: string }) => {
 		const response = await login(
 			process.env.PUBLIC_TEST_USER as string,
 			"invalid-password",
+			AUTH_TYPES.CODE,
 		);
 		if (!response) {
 			console.error(`==> [${Date.now()}] : `, "Login failed");

diff --git a/packages/auth-provider/src/components/AuthProvider/AuthProvider.tsx b/packages/auth-provider/src/components/AuthProvider/AuthProvider.tsx
@@ -190,6 +190,10 @@ export const AuthProvider = ({
 					return true;
 				}
 				removeStateAndLocalStorage(LOGIN_ERROR);
+				setAuthState((prev) => ({
+					...prev,
+					isLoading: false,
+				}));
 				return false;
 			}
 			return false;
@@ -219,6 +223,10 @@ export const AuthProvider = ({
 			return true;
 		}
 		removeStateAndLocalStorage(LOGIN_ERROR);
+		setAuthState((prev) => ({
+			...prev,
+			isLoading: false,
+		}));
 		return false;
 	};