-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SimulcastConsumer: Fix frozen video when syncing keyframe is discarded due to too high RTP timestamp extra offset needed #999
Conversation
…d due to too high RTP timestamp extra offset needed - It may fix #990. - Rationale here: #990 (comment). - Basically we should reset this->syncRequired` nor `this->spatialLayerToSync` when the keyframe that is supposed to switch to another spatial layer is discarded due to too high RTP timestamp extra offset needed.
Pull reviewers statsStats of the last 365 days for mediasoup:
|
NOTE: I'm testing #990 (comment) STR before merging. |
So, I cannot reproduce the issue following STR when using this branch :) These are the logs in this PR/branch, note that "cannot switch stream due to too high RTP timestamp extra offset needed" happens many times. However video is never frozen: [2023-01-31T09:50:51Z DEBUG mediasoup::worker::channel] request succeeded [method:consumer.setPreferredLayers, id:118] |
1 similar comment
So, I cannot reproduce the issue following STR when using this branch :) These are the logs in this PR/branch, note that "cannot switch stream due to too high RTP timestamp extra offset needed" happens many times. However video is never frozen: [2023-01-31T09:50:51Z DEBUG mediasoup::worker::channel] request succeeded [method:consumer.setPreferredLayers, id:118] |
So, I cannot reproduce the issue following STR when using this branch :) These are the logs in this PR/branch, note that "cannot switch stream due to too high RTP timestamp extra offset needed" happens many times. However video is never frozen: [2023-01-31T09:51:04Z DEBUG mediasoup::worker] [id:5f044e7a-0a4f-417a-87d2-128fc8e6cc34] RTC::SimulcastConsumer::UpdateTargetLayers() | target layers changed [spatial:2, temporal:0, consumerId:1925ac4d-d34a-4734-a1a5-571b175a28fd] |
Amazing. Thank you! @nazar-pc I'm using the Rust version and waiting for the release of this fix ;) |
@satoren, Rust version 0.11.3 is out |
…d due to too high RTP timestamp extra offset needed (versatica#999) - Fixes versatica#990. - Rationale here: versatica#990 (comment). - Basically we should reset this->syncRequired` nor `this->spatialLayerToSync` when the keyframe that is supposed to switch to another spatial layer is discarded due to too high RTP timestamp extra offset needed.
nor
this->spatialLayerToSync` when the keyframe that is supposed to switch to another spatial layer is discarded due to too high RTP timestamp extra offset needed.