Added option to automatically determine port to WebRtcServer #908
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Same thing I commented on original PR 🙂 #834 (comment) |
If port is not specified at createWebRtcServer, automatically determine the port of the webrtcserver by Worker's port range
satoren
force-pushed
the
auto_port_webrtc_server
branch
from
e3d6553 to
0fc914a
Compare
satoren
force-pushed
the
auto_port_webrtc_server
branch
from
9c2125e to
4fd4a12
Compare
ibc
requested changes
Sep 20, 2022
|
Lint or something is failing in CI |
satoren
force-pushed
the
auto_port_webrtc_server
branch
from
031c5c6 to
f362b6a
Compare
jmillan
approved these changes
Sep 28, 2022
|
I won't merge it yet since I want to write doc in mediasoup-website project before merging it. If you wish to make a PR to the docs project, you are welcome. Otherwise I'll do hopefully this week. |
ibc
approved these changes
Oct 3, 2022
|
Released in 3.10.8 |
piranna
pushed a commit
to dyte-in/mediasoup
that referenced
this pull request
Feb 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If port is not specified at createWebRtcServer, automatically determine the port of the webrtcserver by Worker's port range
https://mediasoup.discourse.group/t/can-webrtcserver-determine-the-port-automatically/4544/6