Increase DTLS key size #844
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ibc
approved these changes
Jun 24, 2022
|
Should we document this in the worker dtlsXxxxx options? |
|
That on some operating systems depending on OpenSSL configuration they might need larger key size? I mean I can add that, but not sure if it is necessary. |
|
This would just happen if folks pass a 1024 bits cert which is unusual nowadays so I think we are good. |
jmillan
approved these changes
Jun 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was getting
error:0A00018F:SSL routines::ee key too smallerror when running tests on Ubuntu 22.04 and turns out in this version OpenSSL config (that library reads) changed security parameters and doesn't consider 1024-bit key secure anymore.So I have re-generated 4096-bit key so it doesn't complain and tests pass again.
debauchee/barrier#126 (comment) is where I got this hint.