Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TransportCongestionControlClient: allow setting maxOutgoingBitrate before created #833

Merged
merged 1 commit into from
Jun 14, 2022
Merged

TransportCongestionControlClient: allow setting maxOutgoingBitrate before created #833

merged 1 commit into from
Jun 14, 2022

Conversation

ibc
Copy link
Member

@ibc ibc commented Jun 13, 2022

@ibc
TransportCongestionControlClient: allow setting maxOutgoingBitrate be…
6b4a97a 
…fore created

- Fixes #831
- Remove no longer used `RtpBufferSize` in `RtpPacket.hpp`.
@ibc ibc requested a review from jmillan June 13, 2022 14:32
@ibc ibc mentioned this pull request Jun 13, 2022
Closed
@ibc
Copy link
Member Author

ibc commented Jun 13, 2022

@ggarber any thoughts about this?

jmillan
jmillan approved these changes Jun 14, 2022
View reviewed changes
Copy link
Member

@jmillan jmillan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ibc ibc merged commit 8018981 into v3 Jun 14, 2022
@ibc ibc deleted the allow-setting-max-outgoing-bitrate-before-tccclient-is-created branch June 14, 2022 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmillan jmillan jmillan approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SetMaxOutgoingBitrate does not work if set before first consumer created
2 participants
@ibc @jmillan