Download and use MSYS/make locally for Windows postinstall

[snnz]

This makes unnecessary to install MSYS manually and avoids the problem of the incorrect make versions in the PATH.

[nazar-pc]

Makes sense to me overall. Did you test it as a git dependency on Windows already?

[nazar-pc]

process.cwd() is probably not a good idea, since it can be called from anywhere. __dirname should be a better alternative

[snnz]

But the paths in all commands are relative to the cwd.

[nazar-pc]

Hm... yes, other paths are implicitly relative to cwd, but that isn't necessarily what they should be.

[snnz]

Yet this is what they are. 🙂 Currently it looks like the script (with package.json) can be anywhere, but everything else should be in the current directory, rather than vice versa.

[snnz]

I tested it from a local tar obtained by npm pack.

[nazar-pc]

You need to make linter happy

[nazar-pc]

@snnz would you be so kind porting this to Rust as well, please?

[snnz]

Unfortunately, I do not know Rust at all. But since it is not a big task, I've tried to write something similar to the Node version looking at the examples. Probably it is clumsy, but it works. However, I didn't manage to complete the installation, because it failed with an error "Filename longer than 260 characters". There are some really long names like "subprojects/usrsctp-9d6b99b10a70f7a63d21cd80d03c353da9ac19d3/libusrsctp.a.p/C__Users_sergeyn_.cargo_registry_src_github.com-1ecc6299db9ec823_mediasoup-sys-0.3.3_subprojects_usrsctp-9d6b99b10a70f7a63d21cd80d03c353da9ac19d3_usrsctplib_netinet_sctp_cc_functions.c.obj". How do people deal with this?

I also noticed that the script cpu_cores.sh tries to run nproc in MinGW environment and cannot find it. I wonder what MSYS package contains it (if any)? It is not installed with msys-base.

[nazar-pc]

cargo fmt is necessary to run to fix formatting and let CI pass that step.

nproc must be present in one of the MinGW packages, I don't have access to Windows VM right now to check which one it came from.

C__Users_sergeyn_.cargo_registry_src_github.com-1ecc6299db9ec823_mediasoup-sys-0.3.3_subprojects_usrsctp-9d6b99b10a70f7a63d21cd80d03c353da9ac19d3_usrsctplib_netinet_sctp_cc_functions.c.obj is a ridiculous file name, I'll see what can be done about that.

[snnz]

cargo fmt is done.

But as to the nproc, I believe, NUMBER_OF_PROCESSORS environment variable should be used instead in Windows as more reliable (NUM_CORES=$NUMBER_OF_PROCESSORS in cpu_cores.sh)

[nazar-pc]

If it works in both native Windows and MinGW environment - sure, let's use that.

[snnz]

I have added it to the PR, since whether nproc exists somewhere in MinGW or not, this subset of MSYS definitely does not install it.

[ibc]

Thanks a lot.
Is this ready? Tested?

[ibc]

So? Is this ready?

[snnz]

Yes, I suppose so. Github's ci runs without problems, and I also use it successfully to upgrade mediasoup in my dev system.

[ibc]

Running GH CI here. Merging once it passes. Thanks!

[ibc]

Released in 3.11.10. Thanks!