Optimize RTP header extension handling #786
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ations, us better container for two-bytes header extension
ibc
reviewed
Mar 4, 2022
ibc
reviewed
Mar 4, 2022
ibc
reviewed
Mar 4, 2022
ibc
reviewed
Mar 4, 2022
ibc
reviewed
Mar 4, 2022
ibc
reviewed
Mar 4, 2022
ibc
approved these changes
Mar 4, 2022
nazar-pc
approved these changes
Mar 4, 2022
There was a problem hiding this comment.
The first observation here is that for 1-byte extensions there is a limit of 14, so it is way cheaper to just allocate contiguous space for 14 bytes as a static array rather than using red-black tree-based map from standard library. This provides huge savings on trivial temporary heap allocations.
For two-byte header extensions just more efficient data structure is used.
nazar-pc
reviewed
Mar 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Yet another extract from
memory-optimizationsbranch.Use
std::arrayinstead of a map for one byte extensions.