Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Worker: emit "died" before observer "close" #684

Merged
merged 1 commit into from
Oct 18, 2021
Merged

Worker: emit "died" before observer "close" #684

merged 1 commit into from
Oct 18, 2021

Conversation

ibc
Copy link
Member

@ibc ibc commented Oct 17, 2021

Replaces PR #682

Tests added.

@ibc ibc requested a review from nazar-pc October 17, 2021 15:22
@ibc ibc mentioned this pull request Oct 17, 2021
Closed
piranna
piranna approved these changes Oct 17, 2021
View reviewed changes
Copy link
Contributor

@piranna piranna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@ibc ibc merged commit 6ee9362 into v3 Oct 18, 2021
@ibc ibc deleted the worker-emit-died-before-observer-close branch October 18, 2021 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@piranna piranna piranna approved these changes

@nazar-pc nazar-pc Awaiting requested review from nazar-pc

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ibc @piranna