Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Erase the dominantId after removal from the map. #634

Merged
merged 2 commits into from
Aug 13, 2021

Conversation

SteveMcFarlin
Copy link

This fixes a bug where by ActiveSpeakerObserver::CalculateActiveSpeaker()
may cause a crash due to a nullptr. While there is a check after getting
the dominantSpeaker from the map we have notice it will pass the check,
and then crash in EvalActivityScores.

Steve McFarlin added 2 commits August 12, 2021 16:05
This fixes a bug where by ActiveSpeakerObserver::CalculateActiveSpeaker()
may cause a crash due to a nullptr. While there is a check after getting
the dominantSpeaker from the map we have notice it will pass the check,
and then crash in EvalActivityScores.
@ibc ibc merged commit 609fbd4 into versatica:v3 Aug 13, 2021
@ibc
Copy link
Member

ibc commented Aug 13, 2021

Thanks, released in 3.8.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants