-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rust version with thread-based worker #540
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… be accessed, comment-out non-working test, all unlocked tests now pass locally
… included as well
…rresponding notifications
…send request for closing if if is unnecessary
…ize and make sure it is actually publishable
…force docs on public types
…d, BSDs should work
…, skip building C++ libraries on docs.rs
ibc
approved these changes
Apr 2, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice. Merging. Do we need a new mediasoup release? or just a new rust-X.X.X
(which value) git tag? or both?
Git tag |
Tag pushed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR builds on top of capabilities introduced in #533.
Main changes here:
Everything above greatly improves usability of mediasoup crate, there is no need to have NPM installed anymore or build worker manually.
The bulk of the diff is moving tests around since I could no longer send signal to worker to trigger all kinds of edge cases, instead there is a private API now used for testing and not available from integrations tests, so those test cases had to be moved into internal unit tests.