Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Producer scores for Consumers #421

Merged
merged 7 commits into from
Jun 14, 2020
Merged

Producer scores for Consumers #421

merged 7 commits into from
Jun 14, 2020

Conversation

ibc
Copy link
Member

@ibc ibc commented Jun 10, 2020

Solution for #420

Make ConsumerScore include a new producerScores field:

export type ConsumerScore =
{
	/**
	 * The score of the RTP stream of the consumer.
	 */
	score: number;

	/**
	 * The score of the currently selected RTP stream of the producer.
	 */
	producerScore: number;

	/**
	 * The scores of all RTP streams in the producer.
	 */
	producerScores: number[];
}

This way, the consumer side can know what spatial layers are "alive" in the producer side.

CleanShot-2020-06-13-at-12 34 33

ezgif com-resize

@ibc ibc requested a review from jmillan June 10, 2020 23:16
@ibc
Copy link
Member Author

ibc commented Jun 14, 2020

Ready, merging.

@ibc ibc merged commit 9680830 into v3 Jun 14, 2020
@ibc ibc deleted the feature-420 branch June 14, 2020 08:11
@ibc
Copy link
Member Author

ibc commented Jun 14, 2020

Codacy Here is an overview of what got changed by this pull request:

Clones added
============
- worker/src/RTC/SimulcastConsumer.cpp  1
- worker/src/RTC/SvcConsumer.cpp  1
         

See the complete overview on Codacy

@jmillan
Copy link
Member

jmillan commented Jun 15, 2020

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants