Enable liburing by default #1255

ibc · 2023-12-06T13:25:31Z

Now that PR Update worker liburing dependency to 2.4-2 #1254 is merged (AKA new liburing wrap version with @jmillan's fix liburing: fix cc member check mesonbuild/wrapdb#1322) let's enable liburing again by default.
ms_enable_liburing has been replaced with ms_disable_liburing (which of course is false by default).

Add explicit --foreground-scripts to all npm ci commands in CI actions.
Fix meson warning (fixes flatc warning: You should add the boolean check kwarg to the run_command call #1256).

…ands in CI actions

…to avoid issue #1256

ibc added 2 commits December 6, 2023 14:23

liburing: Enable by default

26a17be

Bonus track: add explicit --foreground-scripts to all npm ci comm…

b24789e

…ands in CI actions

ibc requested review from jmillan and nazar-pc December 6, 2023 13:25

Bonus track: add check: true to run_command in our meson.build …

ad9c57d

…to avoid issue #1256

ibc mentioned this pull request Dec 6, 2023

flatc warning: You should add the boolean check kwarg to the run_command call #1256

Closed

jmillan approved these changes Dec 6, 2023

View reviewed changes

ibc merged commit ad2d814 into v3 Dec 6, 2023
36 checks passed

ibc deleted the enable-liburing-by-default branch December 6, 2023 14:17

Provide feedback