Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LibUring: Enable liburing usage for SCTP data delivery #1249

Merged
merged 4 commits into from
Dec 4, 2023
Merged

Conversation

jmillan
Copy link
Member

@jmillan jmillan commented Dec 1, 2023

There are two SCTP delivery scenarios that would benefit of liburing:

1- When Router iterates DataConsumers to deliver a message from a DataProducer.
2- When we call usrsctp_handle_timers() periodically, which will synchronously call the send/recv callbacks for the SctpAssociations.

@ibc
Copy link
Member

ibc commented Dec 1, 2023

When Router iterates DataConsumers to deliver a message from a DataProducer.

This doesn't make sense, do you mean the opposite?

@jmillan
Copy link
Member Author

jmillan commented Dec 1, 2023

When Router iterates DataConsumers to deliver a message from a DataProducer.

This doesn't make sense, do you mean the opposite?

The same as for RTP Producer and Consumers. When Router iterates the Consumers to deliver the RTP packet that we received into a Producer, we activate the ring, which make that those messages will be prepared to use liburing. Once all Consumers have been iterated then DepLibUring::Submit() is called, meaning, all previously prepared messages will now be delivered at once.

Copy link
Member

@ibc ibc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything was good in the description. I should not review after wines.

@ibc
Copy link
Member

ibc commented Dec 4, 2023

Merge?
BTW Changelog changes missing.

@jmillan
Copy link
Member Author

jmillan commented Dec 4, 2023

Adding changelog..

@jmillan jmillan merged commit b986e21 into v3 Dec 4, 2023
35 checks passed
@jmillan jmillan deleted the liburing-sctp branch December 4, 2023 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants