Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve npm-scripts #1207

Merged
merged 1 commit into from
Nov 3, 2023
Merged

Improve npm-scripts #1207

merged 1 commit into from
Nov 3, 2023

Conversation

ibc
Copy link
Member

@ibc ibc commented Nov 3, 2023

  • Do not call cleanWorkerArtifacts() in flatcNode(). No reason for that plus it is bypassing the MEDIASOUP_LOCAL_DEV env purpose.
  • Use more readable object arguments.

@ibc
Improve npm-scripts
846c88b 
- Do not call `cleanWorkerArtifacts()` in `flatcNode()`. No reason for that plus it is bypassing the `MEDIASOUP_LOCAL_DEV` env purpose.
- Use more readable object argumnets.
@ibc ibc requested a review from jmillan November 3, 2023 10:58
jmillan
jmillan approved these changes Nov 3, 2023
View reviewed changes
Copy link
Member

@jmillan jmillan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@ibc ibc merged commit f7e7fce into flatbuffers Nov 3, 2023
30 of 32 checks passed
@ibc ibc deleted the improve-npm-scripts branch November 3, 2023 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmillan jmillan jmillan approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ibc @jmillan