Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FBS: Remove unneeded message type member #1203

Merged
merged 2 commits into from
Oct 30, 2023

Conversation

jmillan
Copy link
Member

@jmillan jmillan commented Oct 30, 2023

It's not needed since the body contained in the message is already typed.

The very same way, we could get rid of method member in request and event member in notification.

It's not needed since the body contained in the message is aleady typed.
@jmillan jmillan force-pushed the fbs-remove-unneeded-message-type branch from 50ac392 to 7baedcc Compare October 30, 2023 14:52
@jmillan jmillan merged commit 66e014e into flatbuffers Oct 30, 2023
32 checks passed
@jmillan jmillan deleted the fbs-remove-unneeded-message-type branch October 30, 2023 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants