Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Google Transport Feedback: read Reference Time field as 24bits signed as per spec #1145

Merged
merged 2 commits into from
Aug 28, 2023
Merged

Google Transport Feedback: read Reference Time field as 24bits signed as per spec #1145

merged 2 commits into from
Aug 28, 2023

Conversation

ibc
Copy link
Member

@ibc ibc commented Aug 28, 2023

Fixes #1144

@ibc ibc requested a review from jmillan August 28, 2023 13:00
@ibc ibc merged commit 9b28af7 into v3 Aug 28, 2023
@ibc ibc deleted the transport-feedback-read-reference-time-as-24bits-signed branch August 28, 2023 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmillan jmillan jmillan approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Reference Time parsing in FeedbackRtpTransport.hpp is wrong (it must be signed)
2 participants
@ibc @jmillan