Fix lost pending statuses in transport feedback #1050
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ibc
reviewed
Apr 4, 2023
| @@ -221,6 +221,8 @@ namespace RTC | |||
| { | |||
| MS_TRACE(); | |||
|
|
|||
| this->transportCcFeedbackPacket->Finish(); | |||
There was a problem hiding this comment.
This is amazing because indeed we were NEVER calling this method (but just in the C++ test).
|
Released in 3.11.21 |
vpalmisano
pushed a commit
to vpalmisano/mediasoup
that referenced
this pull request
Apr 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When sending TransportCcFeedbackPacket it doesn't include all the statuses that were not added to a chunk yet because there was no call to TransportCcFeedbackPacket->Finish() method to add those pending ones before sending the message.
Because of that at a low packet rate (<50 packets / sec) the TransportCCFeedbackPacket is empty most of the time and the bandwidth estimation can not be calculated properly.