Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix check division by zero in transport congestion control #1049

Merged
merged 1 commit into from
Apr 4, 2023
Merged

Fix check division by zero in transport congestion control #1049

merged 1 commit into from
Apr 4, 2023

Conversation

ggarber
Copy link
Contributor

@ggarber ggarber commented Apr 4, 2023

Add check for expected packets in case an empty TransportFeedback RTCP packet is sent or received with 0 packet statuses.

ibc
ibc approved these changes Apr 4, 2023
View reviewed changes
Copy link
Member

@ibc ibc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch.

@ibc ibc merged commit 6c984ae into versatica:v3 Apr 4, 2023
@ibc
Copy link
Member

ibc commented Apr 4, 2023

Released in 3.11.21

vpalmisano pushed a commit to vpalmisano/mediasoup that referenced this pull request Apr 17, 2023
@ggarber @vpalmisano
Fix check division by zero in transport congestion control (versatica…
3603114 
…#1049)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ibc ibc ibc approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ggarber @ibc