Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mediasoup-node: Make appData TS typed and writable #1046

Merged
merged 3 commits into from
Mar 31, 2023
Merged

mediasoup-node: Make appData TS typed and writable #1046

merged 3 commits into from
Mar 31, 2023

Conversation

ibc
Copy link
Member

@ibc ibc commented Mar 31, 2023 •
edited
Loading

Usage (everywhere when creating a mediasoup entity):

const router = await worker.createRouter<{ lalala: number }(options);

const producer = await transport.produce<{ foo: number; bar?: string }(options);

@ibc
mediasoup-node: Make appData TS typed and writable
966b872 
- This PR replaces PR #869 by @mango-martin (credits to him).
- Fixes #1043
@ibc ibc requested review from jmillan and nazar-pc March 31, 2023 11:03
@ibc ibc mentioned this pull request Mar 31, 2023
Closed
jmillan
jmillan approved these changes Mar 31, 2023
View reviewed changes
Copy link
Member

@jmillan jmillan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ibc ibc merged commit b6d23b7 into v3 Mar 31, 2023
@ibc ibc deleted the typed-app-data-and-make-it-writable branch March 31, 2023 11:27
@ibc ibc mentioned this pull request Apr 14, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmillan jmillan jmillan approved these changes

@nazar-pc nazar-pc Awaiting requested review from nazar-pc

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make appData no longer read-only
2 participants
@ibc @jmillan