Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add transport.setMinOutgoingBitrate() (2) #1038

Merged
merged 3 commits into from
Mar 29, 2023

Conversation

ibc
Copy link
Member

@ibc ibc commented Mar 29, 2023

Same PR than https://github.com/versatica/mediasoup/pull/1035/files by @jcague (all credits to him) with some additions such as the ability to reset min/max limits by calling the methods with argument 0 and more tests.

Same PR than https://github.com/versatica/mediasoup/pull/1035/files by @jcague (all credits to him) with some additions such as the ability to reset min/max limits by calling the methods with argument 0 and more tests.
@ibc ibc requested review from jmillan and nazar-pc March 29, 2023 12:30
@ibc
Copy link
Member Author

ibc commented Mar 29, 2023

Off-topic: @nazar-pc the Meson issue when fetching libs is today more annoying than 1 year ago. Are you aware of any progress in whichever side it corresponds? I'm basically restarting failing workflows like crazy.

@nazar-pc
Copy link
Collaborator

Looks like libuv website is down, returns 500 to me 🤷‍♂️

Would be great to have some reliable caching server/CDN in Meson, especially since everything is checked against contents hashes.

@ibc
Copy link
Member Author

ibc commented Mar 29, 2023

Looks like libuv website is down, returns 500 to me 🤷‍♂️

Which URL? I tried the failing one and worked for me.

Would be great to have some reliable caching server/CDN in Meson, especially since everything is checked against contents hashes.

But that's not something we can do.

@ibc
Copy link
Member Author

ibc commented Mar 29, 2023

@nazar-pc please help here, I do NOT understand why this Rust test is failing: https://github.com/versatica/mediasoup/actions/runs/4553997834/jobs/8031278488?pr=1038

@ibc
Copy link
Member Author

ibc commented Mar 29, 2023

@nazar-pc please help here, I do NOT understand why this Rust test is failing: https://github.com/versatica/mediasoup/actions/runs/4553997834/jobs/8031278488?pr=1038

Ignore, missing cargo fmt.

@nazar-pc
Copy link
Collaborator

I tried this:

https://dist.libuv.org/dist/v1.44.2/libuv-v1.44.2.tar.gz

Must be flaky today

@ibc
Copy link
Member Author

ibc commented Mar 29, 2023

I tried this:

https://dist.libuv.org/dist/v1.44.2/libuv-v1.44.2.tar.gz

Must be flaky today

I can download it reliably :(

@ibc ibc merged commit 2744b4c into v3 Mar 29, 2023
@ibc ibc deleted the add-transport-set-min-outgoing-bitrate-2 branch March 29, 2023 13:11
@ibc
Copy link
Member Author

ibc commented Mar 29, 2023

@jcague this is released in 3.11.17 (in 5-10 minutes).

vpalmisano pushed a commit to vpalmisano/mediasoup that referenced this pull request Apr 17, 2023
Same PR than https://github.com/versatica/mediasoup/pull/1035/files by @jcague (all credits to him) with some additions such as the ability to reset min/max limits by calling the methods with argument 0 and more tests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants