Properly handle ksvc bandwidth allocation #1036
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ibc
reviewed
Mar 28, 2023
Do you mean taking into account that logic when we pass |
|
Nope, I mean another thing but maybe we changed it long ago and what I said no longer makes sense. Will recheck tomorrow. |
|
Checking this. |
|
Checking it later today. |
ibc
requested changes
Mar 29, 2023
There was a problem hiding this comment.
Ok @vpalmisano, I found the missing thing:
- See
SimulcastConsumer::GetDesiredBitrate(). It returns the highest bitrate of all its streams (orthis->rtpParameters.encodings[0].maxBitrateif given). - However
SvcConsumer::GetDesiredBitrate()returns the total bitrate of the whole SVC or K-SVC stream. If K-SVC we should just return the bitrate of the spatial layer that produces the most bitrate, right?
NOTE: Consumer::GetDesiredBitrate() is used by Transport::ComputeOutgoingDesiredBitrate() method.
Correct, I'm taking a look. |
ibc
reviewed
Mar 30, 2023
ibc
approved these changes
Mar 30, 2023
|
Releasing in 3.11.19 right now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we use VP9 with K-SVC configuration, the spatial layers are independent; this means that the bandwidth allocator, when it tries to increase the allocated layer, should not take into account the lower spatial levels bitrates (same behaviour of the Simulcast case).