RtpRetransmissionBuffer: get rid of startSeq private member #1029
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- `this->startSeq` is just the seq of the first element in `this->buffer`, nothing else. - It doesn't make sense to have a separate member just for it. - We can just read `sequenceNumber` in the oldest item in the buffer. - The recent crash reported in #1027 was caused due to a non properly updated `this->startSeq`. So let's get rid of it completely.
ibc
commented
Mar 22, 2023
ibc
commented
Mar 22, 2023
nazar-pc
approved these changes
Mar 22, 2023
nazar-pc
approved these changes
Mar 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this->startSeqis just the seq of the first element inthis->buffer, nothing else.sequenceNumberin the oldest item in the buffer.this->startSeq. So let's get rid of it completely.