-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Should not announce RTP MID extension support for "recv" transport #230
Comments
ALERT: This makes Chrome to not receive media from any browser. It works fine with Firefox, and Firefox receives media from Chrome, but Chrome does not receive media from Chrome or Firefox. |
So here the problem:
So the solution is in mediasoup-client: Don't include the MID RTP extension in "recv" transports. |
This is fixed in |
Have you filed a bug for this? |
How do Chrome <-> Chrome calls work at all if will negotiate it, but not send it and throw away packets with incorrect/missing MIDs? |
And yes you are correct that Firefox has not implemented the last pieces for MID support: paying attention to it on received packets and route them based on that. |
Hi all, confirmed that I did something wrong yesterday when debugging the packets sent by Chrome. Indeed they do contain MID value. So the issue (which in fact is not an issue) is:
I would expect that, since I assume Firefox will behave the same way when MID stuff finished, is this right, @nils-ohlmeier ? NOTE: Our solution is: in |
So it's important to upgrade to mediasoup-client 2.4.2 if you also upgrade mediasoup (server) to 2.5.2. |
Since MID superseeds SSRC's I think what Chrome is doing is right. If you receive packets with unknown MID's throw them away. SSRC's are pretty pointless if everyone and everything is using MID's, with the one exception being RTX (one of the reasons I'm not a big fan of that feature). |
Sounds legitimate.
I don't agree here:
|
mediasoup can read RTP MID values in received packets to match the corresponding
Producer
. However we should not tell the remoteConsumers
that we supporta=mid
since the RTP MID value that the remoteConsumer
will receive will not match thea=mid
of its internally generated remote SDP offer.It seems that Firefox (the only browser supporting MID for now) does not complain if the RTP MID does not match any
a=mid
, and performs m section lookup based on SSRC. But anyway we should not announce something that we are wrongly using.The text was updated successfully, but these errors were encountered: