Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PlainRtpTransport may leak #224

Closed
ibc opened this issue Nov 16, 2018 · 2 comments
Closed

PlainRtpTransport may leak #224

ibc opened this issue Nov 16, 2018 · 2 comments
Assignees
@ibc @jmillan
Labels
bug
Milestone
v2 updates

Comments

@ibc
Copy link
Member

ibc commented Nov 16, 2018

Full rationale in #222. It will leak if, for any reason, SetRemoteParameters() fails in the constructor.

Lesson learned: If B is child of A and B constructor throws an exception, B destructor won't be called, but A destructor will be.
@ibc ibc added the bug label Nov 16, 2018
@ibc ibc added this to the v2 updates milestone Nov 16, 2018
@ibc ibc assigned ibc and jmillan Nov 16, 2018
@ibc
Copy link
Member Author

ibc commented Nov 16, 2018

We should probably take a proper look to all this stuff since I don't like much how we deal with custom Destroy() methods that call delete this and so on.

@ibc
Copy link
Member Author

ibc commented Nov 17, 2018

Basically, if SetRemoteParameters() fails in line 39, this->udpSocket would leak.

jmillan added a commit that referenced this issue Nov 19, 2018
@jmillan
close #224. Avoid memory leak when PlainRtpTransport constructor throws
66fc62a
lavarsicious pushed a commit to lavarsicious/mediasoup that referenced this issue Feb 5, 2019
@jmillan @lavarsicious
close versatica#224. Avoid memory leak when PlainRtpTransport constru…
cb1d640 
…ctor throws (versatica#225)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ibc ibc

@jmillan jmillan

Labels
bug
Milestone
v2 updates
Development

No branches or pull requests
2 participants
@ibc @jmillan