Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plain Transport Custom RTCP Port #1096

Closed
ezioda004 opened this issue May 31, 2023 · 6 comments · Fixed by #1099
Closed

Plain Transport Custom RTCP Port #1096

ezioda004 opened this issue May 31, 2023 · 6 comments · Fixed by #1099
Labels

Comments

@ezioda004
Copy link

Feature Request

When we create PlainTransport with rtcpMux false, then the transport uses 2 ports. One for RTP and the other for RTCP. While creating we can pass the port to router.createPlainTransport(), however, the RTCP port is selected from the worker's port range. I'm requesting an option to pass down a custom RTCP port to router.createPlainTransport(), so the application layer can manage this port. In our app, we're already managing pipe transport ports and with the addition of plain transport, we're only able to manage RTP ports and not RTCP.

@ibc
Copy link
Member

ibc commented Jun 1, 2023

PR done here: #1099

However, note that such a PR targets flatbuffers branch which has an ongoing PR #1064. So this feature will be in v3 once both PRs are merged.

@ibc ibc linked a pull request Jun 1, 2023 that will close this issue
@ezioda004
Copy link
Author

This is great, however, I was expecting an option like rtcpPort like we have a port option in PlainTransportOptions. Would it make sense to add this option alongside rtcpListenInfo?

@ibc
Copy link
Member

ibc commented Jun 1, 2023

This is great, however, I was expecting an option like rtcpPort like we have a port option in PlainTransportOptions. Would it make sense to add this option alongside rtcpListenInfo?

Definitely not. ListenInfo is the way to go once flatbuffers branch is merged in v3, and ListenIp will be deprecated. Some for port option in every router.createXxxTransport() API.

@ezioda004
Copy link
Author

Definitely not. ListenInfo is the way to go once flatbuffers branch is merged in v3, and ListenIp will be deprecated. Some for port option in every router.createXxxTransport() API.

Ok, so listenInfo and now rtcpListeninfo will replace listenIp, port. Understood.

@ibc
Copy link
Member

ibc commented Jun 1, 2023

Will not replace because the former options will still be available to not break backwards compatibility, but I don't want to add already deprecated new options.

@ibc
Copy link
Member

ibc commented Dec 30, 2023

This was done long ago.

@ibc ibc closed this as completed Dec 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging a pull request may close this issue.

2 participants