Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WebSocket reconnection issues #148

Closed
gavllew opened this issue Aug 19, 2013 · 0 comments
Closed

WebSocket reconnection issues #148

gavllew opened this issue Aug 19, 2013 · 0 comments

Comments

@gavllew
Copy link
Contributor

gavllew commented Aug 19, 2013

Noticed two issues with WebSocket disconnection in Transport.js:

  • The reconnection_attempts counter is reset to 0 every time a WebSocket closes, so the counter never exceeds 1.
  • If the disconnect method is called while the reconnect timer is running, the timer is not stopped, so a new WebSocket connection is made later (when UA thinks it has stopped).

Pull request to follow.
@jmillan jmillan mentioned this issue Aug 23, 2013
Merged
jmillan added a commit that referenced this issue Nov 13, 2013
@jmillan
Merge pull request #149 from crocodilertc/issue-148
ed643f7 
Fix #148: WebSocket reconnection behaviour
jmillan pushed a commit that referenced this issue Nov 13, 2013
@jmillan
Fix #148: WebSocket reconnection behaviour
7be0a13
jmillan pushed a commit that referenced this issue Nov 13, 2013
@jmillan
Fix #148: WebSocket reconnection behaviour
22c7785
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@gavllew