-
Notifications
You must be signed in to change notification settings - Fork 749
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix #176. Update to the latest IceServer definition
Old: dictionary RTCIceServer { DOMString url; DOMString? credential; }; New: dictionary RTCIceServer { (DOMString or sequence<DOMString>) urls; DOMString? username = null; DOMString? credential; }; Note: Current Firefox Nightly "28.0a1 (2013-11-18)" Does not support multiple 'urls'
- Loading branch information
Showing
2 changed files
with
28 additions
and
15 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
62e8323
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If there no stun_servers specified then the following line:
servers.push({'url': config.stun_servers});
add an empty url element which causes Chrome and Firefox to complain.
Reverting to the previous code works better!
62e8323
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A default 'stun_servers' value is set in case you don't define it, so it is never empty.
Please, paste here the error you are getting, and the full JsSIP log.
62e8323
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, the problem only appears if I set "stun_servers" as [] in the configuration object. If I omit it entirely or set a string within the array it works fine.
I can live with that! Thanks for looking.
62e8323
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just pushed a commit in the 'develop' branch that addresses the empty array as an empty configuration option. 0a5bccd
Thanks
62e8323
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This fix broke our implementation. An empty array should be allowed (with the meaning: do not use any STUN servers). Using WebRTC without STUN servers works fine (under some network conditions) in current browsers and should be possible. Please revert to previous state, with for loop.
62e8323
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's address this in #206.