-
Notifications
You must be signed in to change notification settings - Fork 749
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Allow passing an empty array as a configuration parameter.
- Loading branch information
Showing
1 changed file
with
2 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0a5bccd
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Explicitly setting a value of empty string or empty array should not be filtered away, this will break some implementations. There are occasions when an empty string or array are useful, and this is the desired value to use (in our case to send an empty list of STUN servers).
Please count only undefined and null as a request for default value! Thanks.
0a5bccd
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right.
Even more: I think that the default value for "stun_servers" should be an empty array (so no STUN servers).
0a5bccd
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's address this in #206.