Fix X, Y logical range, sample QE inputs #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ASleepyCat
force-pushed
the
fix-logical-range
branch
from
51a6e7d to
178e867
Compare
ASleepyCat
force-pushed
the
fix-logical-range
branch
from
178e867 to
5943fb8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been running this firmware for a few years now, ever since the last commit to the
roxybranch three years ago. I wanted to resolve the jittery QE inputs without using a deadzone, which lead me to sample from QE1000128 times per loop (I'm pretty sure I got this idea from another arcin fw fork, but I didn't write down where).This mostly solves the issue, except rarely it'll jitter very slightly. This jitter won't ever be visible in gameplay, because I've only noticed it in spicecfg.Reducing down to 128 samples has fixed the jitter entirely.I've also changed the X and Y logical ranges to
[0, 255]. This fixes an issue where analog controls will get stuck at 100% for a few spins after first plugging in.